Re: [PATCH] mmc: dw_mmc should depend on COMMON_CLK
From: Geert Uytterhoeven
Date: Mon Jul 02 2018 - 09:32:54 EST
On Mon, Jul 2, 2018 at 3:18 PM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> On 6 June 2018 at 20:43, Corentin Labbe <clabbe@xxxxxxxxxxxx> wrote:
> > This patch fix the following build failure on m68k:
> > ERROR: "clk_set_rate" [drivers/mmc/host/dw_mmc.ko] undefined!
> > Signed-off-by: Corentin Labbe <clabbe@xxxxxxxxxxxx>
> Thanks, applied for next!
Please drop this patch, I posted proper fixes for this general issue in series
"[PATCH 0/3] Legacy clock drivers: Normalize clk API"
All fixes above are already in next-20180702.
> > ---
> > drivers/mmc/host/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 0581c199c996..77d6ba090436 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -666,7 +666,7 @@ config MMC_CAVIUM_THUNDERX
> > config MMC_DW
> > tristate "Synopsys DesignWare Memory Card Interface"
> > - depends on ARC || ARM || ARM64 || MIPS || COMPILE_TEST
> > + depends on COMMON_CLK && (ARC || ARM || ARM64 || MIPS || COMPILE_TEST)
> > help
> > This selects support for the Synopsys DesignWare Mobile Storage IP
> > block, this provides host support for SD and MMC interfaces, in both
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds