Re: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods
From: Andy Shevchenko
Date: Mon Jul 02 2018 - 10:06:22 EST
On Mon, Jul 2, 2018 at 4:51 PM, <Mario.Limonciello@xxxxxxxx> wrote:
>> > So there are some customers who will have issue with power button
>> > without this patch, so it should be also marked for stable also.
>> > Also this may be a candidate for 4.18-rcX.
>> I'm not sure Greg will take this selling point for rather big patch.
>> From changelog, honestly, I don't see any regression description,
>> looks like "it wasn't working before change anyway".
> Just for adding some context.
> Some platforms have moved to different interface in ASL in FW upgrade
> due to deficiencies/bugs present with old interface. So yes it's platform FW
> change in behavior that leads to Linux kernel regression. Windows driver has supported
> both interfaces for a long time. Linux kernel however doesn't support this interface until now.
>> For now, I pushed this to my review and testing queue as is, thanks!
> If not stable I think it would at least be ideal to try to bring this to 4.18-rcX if possible for
> compatibility with more platforms that will come with this other interface instead.
--- 8< --- 8< ---
So please, people, the "fixes" during the rc series really should be
things that are _regressions_. If it used to work, and it no longer does,
then fixing that is a good and proper fix. Or if something oopses or has a
security implication, then the fix for that is a real fix.
But if it's something that has never worked, even if it "fixes" some
behavior, then it's new development, and that should come in during the
merge window. Just because you think it's a "fix" doesn't mean that it
really is one, at least in the "during the rc series" sense.
--- 8< --- 8< ---
So, if we can sell him that it used to work and firmware fix is a
Linux regression I'm fine.
Darren, what do you think?
With Best Regards,