Re: [PATCH v6 05/21] KVM: s390: CPU model support for AP virtualization

[Halil Pasic]

On 07/02/2018 05:37 PM, Tony Krowiak wrote:
> On 07/02/2018 10:38 AM, Christian Borntraeger wrote:
> > On 06/29/2018 11:11 PM, Tony Krowiak wrote:
> > > Introduces a new CPU model feature and two CPU model
> > > facilities to support AP virtualization for KVM guests.
> > >
> > > CPU model feature:
> > >
> > > The KVM_S390_VM_CPU_FEAT_AP feature indicates that
> > > AP instructions are available on the guest. This
> > > feature will be enabled by the kernel only if the AP
> > > instructions are installed on the linux host. This feature
> > > must be specifically turned on for the KVM guest from
> > > userspace to use the VFIO AP device driver for guest
> > > access to AP devices.
> > >
> > > CPU model facilities:
> > >
> > > 1. AP Query Configuration Information (QCI) facility is installed.
> > >
> > > ÂÂÂ This is indicated by setting facilities bit 12 for
> > > ÂÂÂ the guest. The kernel will not enable this facility
> > > ÂÂÂ for the guest if it is not set on the host. This facility
> > > ÂÂÂ must not be set by userspace if the KVM_S390_VM_CPU_FEAT_AP
> > > ÂÂÂ feature is not installed.
> > >
> > > ÂÂÂ If this facility is not set for the KVM guest, then only
> > > ÂÂÂ APQNs with an APQI less than 16 will be available to the
> > > ÂÂÂ guest regardless of the guest's matrix configuration. This
> > > ÂÂÂ is a limitation of the AP bus running on the guest.
> > >
> > > 2. AP Facilities Test facility (APFT) is installed.
> > >
> > > ÂÂÂ This is indicated by setting facilities bit 15 for
> > > ÂÂÂ the guest. The kernel will not enable this facility for
> > > ÂÂÂ the guest if it is not set on the host. This facility
> > > ÂÂÂ must not be set by userspace if the KVM_S390_VM_CPU_FEAT_AP
> > > ÂÂÂ feature is not installed.
> > >
> > > ÂÂÂ If this facility is not set for the KVM guest, then no
> > > ÂÂÂ AP devices will be available to the guest regardless of
> > > ÂÂÂ the guest's matrix configuration. This is a limitation
> > > ÂÂÂ of the AP bus running under the guest.
> > >
> > > Reviewed-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> > > Reviewed-by: Halil Pasic <pasic@xxxxxxxxxxxxx>
> > > Signed-off-by: Tony Krowiak <akrowiak@xxxxxxxxxxxxx>
> > I think it probably should be at the end of the series, other than that its good.
>
> If I move this to the end of the series, the very next patch checks the
>
> KVM_S390_VM_CPU_FEAT_AP feature?

The point is the following: never expose a feature *before* it
is actually provided. And this is exactly what you are doing here.

AFAIU the userspace can happily negotiate KVM_S390_VM_CPU_FEAT_AP,
do it's part of the job and still not have AP instructions in the guest
if patches [0..5] are applied but [6..21] not. This is wrong.

AFAIR I requested this one being squashed with the next one for exact
this reason. That would be OK as starting with patch 6 applied we
do satisfy what the features require. It's only that the interfaces
required to set up the resources are not there yet and thus the features
can't really be used meaningfully.

Usually we expose the features at the end of a series, as such a series
often just implements support for the given feature(s).

In this special IMHO case we can get away with not doing so, but not
exposing the feature until the end of the series could still have some
merit.

Anyway we should avoid exposing half-assed stuff. In that sense the
resource cleanup (zapq) logic must not be introduced after
resources can be acquired and utilized.

Regards,
Halil