Re: [PATCH] bus: ti-sysc: Use 2-factor allocator arguments

From: Kees Cook
Date: Mon Jul 02 2018 - 12:14:15 EST

On Mon, Jul 2, 2018 at 4:27 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> * Kees Cook <keescook@xxxxxxxxxxxx> [180627 21:59]:
>> On Mon, Jun 18, 2018 at 10:45 AM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>> > This adjusts the allocator calls to use 2-factor argument call style, as
>> > done treewide already for improved defense against allocation overflows.
>> >
>> > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>> Friendly ping! :) This is the last 2-factor devm* allocation left in
>> 4.18 to be fixed.
> Sorry for the delay on this one. As we're already at -rc3, I'll apply
> this into omap-for-v4.19/ti-sysc. Seems there should not be need to rush
> this into v4.18-rc cycle, but please do let me know if that is not the
> case.

I'd like to be able to reason about multiplication vs allocator uses
in 4.18 and later. Since all other allocators got fixed in 4.18, I'd
really like to have this one fixed too, then the scripts that check
for multiplications in single-argument allocators will run clean for

So, it's not strictly a "rush", but it would be appreciated. :)


Kees Cook
Pixel Security