Re: [PATCH] selinux: Use pr_fmt to prefix "SELinux: "
From: Joe Perches
Date: Mon Jul 02 2018 - 22:10:15 EST
On Mon, 2018-07-02 at 21:15 -0400, Paul Moore wrote:
> On Mon, Jul 2, 2018 at 5:31 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
> > On Mon, 2018-07-02 at 16:51 -0400, Paul Moore wrote:
> > > On Wed, Jun 20, 2018 at 2:39 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
> > > > pr_fmt can be used with the pr_<level> macros to prefix
> > > > arbitrary content to logging messages.
> > > >
> > > > So add '#define pr_fmt(fmt) "SELinux: " fmt' to selinux files
> > > > that use pr_<level> and remove embedded "SELinux: " prefixes
> > > > from the format strings.
> > 
> > > What tree did you base your patch on?
> > next-20180619 on the day it was sent.
> > > Please base SELinux patches
> > > either on the SELinux tree or Linus' tree. The SELinux tree can be
> > > found at the links below:
> > >
> > > * git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git
> > > * https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git
> > It's almost always better to use selinux/next.
> > Why should this patch be different?
> Yes, that's what I said, please base your patch against the selinux/next branch.
Again, this patch was based on that branch on the date the
patch was sent.
It still applies today to -next.