Re: [PATCH V2] mmc: core: cd_label must be last entry of mmc_gpio struct

From: Fabio Estevam
Date: Mon Jul 02 2018 - 22:25:48 EST

On Mon, Jul 2, 2018 at 11:13 PM, Anson Huang <anson.huang@xxxxxxx> wrote:

> I think either way is OK, since flexible array is used in kernel code quite commonly,
> so I prefer to make code change as small as possible, the original patch can also prevent
> similar bug in future. And like below commit Fabio pointed out, it also has same kind
> of fix: a158531f3c92 ("gpio: 74x164: Fix crash during .remove()"). Thanks.

I am also fine with this patch or the one from Linus.

Maybe Anson's patch could be applied to 4.18-rc as a bug fix and
Linus' patch could be applied to 4.19-rc1 as a cleanup/improvement?


What would you prefer?