Re: [RFC PATCH 1/4] dts: misc: Add bindings documentation for bmc-misc-ctrl
From: Greg KH
Date: Tue Jul 03 2018 - 10:31:17 EST
On Wed, Jul 04, 2018 at 12:16:49AM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2018-07-03 at 09:50 +0200, Greg KH wrote:
> > On Tue, Jul 03, 2018 at 05:04:10PM +1000, Andrew Jeffery wrote:
> > > Signed-off-by: Andrew Jeffery <andrew@xxxxxxxx>
> > > ---
> > I can't take patches without any changelog text at all :(
> Greg (and replying to your other comments as well)...
> This is an RFC series, it's not meant for you to take at this point,
> it's about discussing the overall approach to exposing BMC random
> "tunables" as explained in patch 0 of the series.
> Yes the individual patches aren't yet at the level of polish for a
> formal submission, we (naively ?) thought that's what the whole RFC tag
> is about :-)
Oh come on, putting a basic "here is what this patch does" comment
should be part of every patch, otherwise what is there to comment on if
we don't know what is going on in the patch itself?
Anyway, I provided a bunch of feedback to the "real" patch in this