Re: [RFC PATCH for 4.18] rseq: use __u64 for rseq_cs fields, validate user inputs
From: Linus Torvalds
Date: Tue Jul 03 2018 - 13:10:55 EST
On Tue, Jul 3, 2018 at 9:40 AM Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> So it sounds like architectures that don't have an instruction atomic u64
> *_user need to disable interrupts during the access, and somehow handle that
> case when a page fault happens?
No. It's actually the store by *user* space that is the critical one.
Not the whole 64-bit value, just the low pointer part.
The kernel could do it as a byte-by-byte load, really. It's
per-thread, and once the kernel is running, it's not going to change.
The kernel never changes the value, it just loads it from user space.
So all the atomicity worries for the kernel are a red herring. They'd
arguably be nice to have - but only for an insane case that makes
absolutely no sense (a different thread trying to change the value).
Can we please stop the idiocy already? The kernel could read the rseq
pointer one bit at a time, and do a little dance with "yield()" in
between, and take interrupts and page faults, and it wouldn't matter
It's not even that we read the value from an interrupt context, it's
that as we return to user space (which can be the result of an
interrupt) we can read the value.
This whole thread has been filled with crazy "what if" things that don't matter.