[PATCH] checkpatch: Check for illegal return codes

From: Prakruthi Deepak Heragu
Date: Tue Jul 03 2018 - 14:09:52 EST

The only legal integer return is 0, anything else
following "return" should be -ERRCODE or a function.

There's lots of "return -1;" statements in this patch - it's obscene
that this is used to indicate "some error occurred" in kernel space
rather than a real errno value - even when an existing function
(eg, request_irq) gave you an error code already.

Signed-off-by: Patrick Pannuto <ppannuto@xxxxxxxxxxxxxx>
Signed-off-by: Stepan Moskovchenko <stepanm@xxxxxxxxxxxxxx>
Signed-off-by: Prakruthi Deepak Heragu <pheragu@xxxxxxxxxxxxxx>
scripts/checkpatch.pl | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a9c0550..260d252 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6197,6 +6197,12 @@ sub process {
"switch default: should use break\n" . $herectx);

+# check for return codes on error paths
+ if ($line =~ /\breturn\s+-\d+/) {
+ "illegal return value, please use an error code");
+ }
# check for gcc specific __FUNCTION__
if ($line =~ /\b__FUNCTION__\b/) {
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project