Re: [PATCH v2] leds: ledtrig-morse: send out morse code

From: Pavel Machek
Date: Wed Jul 04 2018 - 02:53:13 EST

On Tue 2018-07-03 17:53:28, Andreas Klinger wrote:
> Send out a morse code by using LEDs.
> This is useful especially on embedded systems without displays to tell the
> user about error conditions and status information.
> The trigger will be called "morse"
> The string to be send is written into the file morse_string and sent out
> with a workqueue. Supported are letters and digits.
> With the file dot_unit the minimal time unit can be adjusted in
> milliseconds.
> Also add documentation for the morse led trigger
> Thanks to Greg and Geert for suggesting improvements
> Signed-off-by: Andreas Klinger <ak@xxxxxxxxxxxxx>

As I stated before, I don't think morse encoder belongs in kernel.

LED pattern trigger should be merged, instead.

(cesky, pictures)

Attachment: signature.asc
Description: Digital signature