Re: [PATCH v2] mfd: dln2: use irqsave() in USB's complete callback
From: Lee Jones
Date: Wed Jul 04 2018 - 03:40:32 EST
On Mon, 02 Jul 2018, Sebastian Andrzej Siewior wrote:
> The USB completion callback does not disable interrupts while acquiring
> the lock. We want to remove the local_irq_disable() invocation from
> __usb_hcd_giveback_urb() and therefore it is required for the callback
> handler to disable the interrupts while acquiring the lock.
> The callback may be invoked either in IRQ or BH context depending on the
> USB host controller.
> Use the _irqsave() variant of the locking primitives.
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: Octavian Purdila <tavi@xxxxxxxxx>
> Reviewed-by: Johan Hovold <johan@xxxxxxxxxx>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> v1âv2: Remove also the comment that says that there is no need to
> disable interrupts.
> drivers/mfd/dln2.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog