Re: [PATCH 3/3] fs/dax: Assigning NULL to gfn of dax_direct_access if useless
From: Dan Williams
Date: Wed Jul 04 2018 - 10:41:44 EST
On Wed, Jul 4, 2018 at 7:37 AM, Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
> On Wed, Jul 4, 2018 at 6:07 AM, Huaisheng Ye <yehs2007@xxxxxxxx> wrote:
>> ---- On Wed, 04 Jul 2018 19:30:12 +0800 Jan Kara <jack@xxxxxxx> wrote ----
>> > On Wed 04-07-18 14:40:58, Huaisheng Ye wrote:
>> > > From: Huaisheng Ye <yehs1@xxxxxxxxxx>
>> > >
>> > > Some functions within fs/dax don't need to get gfn from direct_access.
>> > > Assigning NULL to gfn of dax_direct_access is more intuitive and simple
>> > > than offering a useless local variable.
>> > >
>> > > Signed-off-by: Huaisheng Ye <yehs1@xxxxxxxxxx>
>> > I like this. You can add:
>> > Reviewed-by: Jan Kara <jack@xxxxxxx>
>> > for the series.
>> > Honza
>> I am so happy you like them, thank you very much.
> Yes, I like this too. In fact I have a similar patch in my tree
> already that I have been preparing to send out. I am using it to delay
> when we need to have the 'struct page' memmap for dax initialized.
> Attached is the full patch, but the series is still a work in
Btw, I'll drop my version and apply your series since you got it
posted first and it can stand alone as its own cleanup.