Re: [PATCH] drm/amd/display/dc/dce: Fix multiple potential integer overflows

[Gustavo A. R. Silva]

On 07/04/2018 12:51 PM, Harry Wentland wrote:
[..]
>>>  
>>> @@ -145,8 +145,8 @@ static bool calculate_fb_and_fractional_fb_divider(
>>>   * of fractional feedback decimal point and the fractional FB Divider precision
>>>   * is 2 then the equation becomes (ullfeedbackDivider + 5*100) / (10*100))*/
>>>  
>>> -	feedback_divider += (uint64_t)
>>> -			(5 * calc_pll_cs->fract_fb_divider_precision_factor);
>>> +	feedback_divider += 5UL *
>>> +			    calc_pll_cs->fract_fb_divider_precision_factor;
>>
>> This should be 5ULL, as the commit log says, otherwise it's still only
>> 32 bits on 32-bit platforms.
>>
> 
> Agreed.
> 
> Otherwise this looks good.
> 
> With that fixed this patch is
> Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx>
> 

Hi Harry,

I already sent v2: https://patchwork.kernel.org/patch/10506897/

Thanks
--
Gustavo