Re: [PATCH v2] gpu: drm: omapdrm: Adding new typedef vm_fault_t
From: Souptick Joarder
Date: Thu Jul 05 2018 - 00:41:34 EST
On Fri, Jun 8, 2018 at 4:17 PM, Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
> On Fri, Jun 8, 2018 at 11:47 AM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote:
>> On 22/05/18 21:13, Souptick Joarder wrote:
>>> Use new return type vm_fault_t for fault handler. For
>>> now, this is just documenting that the function returns
>>> a VM_FAULT value rather than an errno. Once all instances
>>> are converted, vm_fault_t will become a distinct type.
>>> Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t")
>>> Previously vm_insert_mixed() returns err which driver
>>> mapped into VM_FAULT_* type. Also return value of
>>> vm_insert_mixed() not handled correctly and 0 was
>>> returned inside fault_2d() as default. The new function
>>> vmf_insert_mixed() will replace this inefficiency by
>>> returning correct VM_FAULT_* type.
>>> vmf_error() is the newly introduce inline function
>>> in 4.17-rc6.
>>> Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
>>> Reviewed-by: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
>>> v2: Fixed kbuild error by initialized ret
>>> in fault_2d().
>>> drivers/gpu/drm/omapdrm/omap_gem.c | 51 +++++++++++++++++---------------------
>>> drivers/gpu/drm/omapdrm/omap_gem.h | 3 ++-
>>> 2 files changed, 25 insertions(+), 29 deletions(-)
>> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
>> It's too late to get this to 4.18 via my normal routes. If you have
>> other similar patches queued and Linus/maintainers are ok to merge this
>> late, feel free to queue this that way.
>> Otherwise I can pick this up for my 4.19 patches.
> 4.19 looks ok. In case, we have pushed this patch into 4.18-rc-x along
> with few others, will notify you.
Tomi, this patch can be merged in 4.19.