Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset
From: Tony Lindgren
Date: Thu Jul 05 2018 - 01:55:17 EST
* Faiz Abbas <faiz_abbas@xxxxxx> [180704 13:37]:
> After taking a second look at this thread, I don't see anything big to
> be modified.
> We both agree that "reset status bit in sysconfig register" is the quirk
> case which can be added once such an IP is discovered in ti-sysc.
> All I need to change is SYSC_OMAP4_SOFTRESET to SYSC_SOFT_RESET_SHIFT_0
> for better readability and rebase it to the latest mainline.
Let's not change SYSC_OMAP4_SOFTRESET as only the ti-sysc
driver needs to know that and it can be set based on the
How about replace ddata->cfg.quirks & SYSC_QUIRK_RESET_STATUS
test with just ddata->cfg.syss_mask test in your sysc_reset()?
We still need to set SYSC_QUIRK_RESET_STATUS too for pdata