Re: [RFC PATCH v4 05/12] sched/topology: Reference the Energy Model of CPUs when available

From: Peter Zijlstra
Date: Thu Jul 05 2018 - 14:14:31 EST


On Thu, Jul 05, 2018 at 06:50:22PM +0100, Quentin Perret wrote:
> On Thursday 05 Jul 2018 at 19:33:21 (+0200), Peter Zijlstra wrote:
> > On Thu, Jun 28, 2018 at 12:40:36PM +0100, Quentin Perret wrote:
> > > + if (cpumask_equal(doms_new[i], doms_cur[j])
> > > + && cpu_rq(cpumask_first(doms_cur[j]))->rd->fd)
> >
> > Please put the operator at the end of the previous line, not the begin
> > of the next line when splitting.
>
> I did that to be consistent with the to similar loops above, but n/p,
> I'll change it :-)

In that case, feel free to fix those too ;-)