Re: [kbuild-all] [PATCH 3/6] timex: prepare compat helpers for y2038 changes
From: Philip Li
Date: Thu Jul 05 2018 - 20:31:03 EST
On Thu, Jul 05, 2018 at 02:45:05PM -0700, Deepa Dinamani wrote:
> Posted v2 now.
> Also the make.cross script pointed to by the kernel test bot is broken
> for riscv.
> I applied the following fix to compile it.
> Pull request: https://github.com/intel/lkp-tests/pull/11
thanks Deepa, i will follow up with the pull request to merge it.
> On Thu, Jul 5, 2018 at 1:33 PM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> > On Thu, 5 Jul 2018, Deepa Dinamani wrote:
> >> The error is fixed with the following patch that goes in before patch
> >> 3/6 above in the series.
> >> Let me know if I should post a v2 instead.
> >> Thanks,
> >> Deepa
> >> commit bfe4b046ed7f01154aef44fcb77d3f172929ccc2
> >> Author: Deepa Dinamani <deepa.kernel@xxxxxxxxx>
> >> Date: Thu Jul 5 11:47:25 2018 -0700
> >> riscv: Include asm-generic/compat.h
> >> riscv does not enable CONFIG_COMPAT in default configurations:
> >> defconfig, allmodconfig and nomodconfig.
> >> And hence does not inlude definitions for compat data types.
> >> Now that time syscalls are being reused in non CONFIG_COMPAT
> >> modes, include asm-generic definitions for riscv.
> >> Alternative would be to make compat_time.h to be conditional on
> >> CONFIG_COMPAT_32BIT_TIME. But, since riscv is already has an
> >> asm/compat.h include the generic version instead.
> >> Signed-off-by: Deepa Dinamani <deepa.kernel@xxxxxxxxx>
> >> Cc: palmer@xxxxxxxxxx
> >> Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx
> > Post a real patch please instead of something which I have to cleanup
> > manually. A V2 of the series is probably the simplest way.
> > Thanks,
> > tglx
> kbuild-all mailing list