Re: [PATCH] dmaengine: nbpfaxi: Mark expected switch fall-through

From: Vinod
Date: Fri Jul 06 2018 - 01:56:45 EST


On 02-07-18, 13:06, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> ---
> drivers/dma/nbpfaxi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/nbpfaxi.c b/drivers/dma/nbpfaxi.c
> index 2f9974d..8c7b2e8 100644
> --- a/drivers/dma/nbpfaxi.c
> +++ b/drivers/dma/nbpfaxi.c
> @@ -479,6 +479,7 @@ static size_t nbpf_xfer_size(struct nbpf_device *nbpf,
>
> default:
> pr_warn("%s(): invalid bus width %u\n", __func__, width);
> + /* fall through */

Hmm this looks okay but am not able to trigger this warning..(used W=1) Did you
see this warning on your build, if so what options?

--
~Vinod