Re: [PATCH] iio: dac: remove redundant variable 'shift'
From: Jonathan Cameron
Date: Sat Jul 07 2018 - 12:45:57 EST
On Mon, 2 Jul 2018 12:43:20 +0200
Sean NyekjÃr <sean.nyekjaer@xxxxxxxxx> wrote:
> On 2018-07-02 12:24, Colin King wrote:
> > From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> > Variable shift is being assigned but is never used hence it is
> > redundant and can be removed.
> > Cleans up two clang warnings:
> > warning: variable âshiftâ set but not used [-Wunused-but-set-variable]
> > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> Reviewed-by: Sean Nyekjaer <sean.nyekjaer@xxxxxxxxx>
> Good catch :-)
As ever, thanks for the patch!
If you wouldn't mind putting the name of the driver in question in patches
like these that would be great. There are enough drivers, that I doubt
anyone (other than me) looks at all patches for DACs. They only look at
the particular parts they actually have on boards ;)
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.