Re: [PATCH v4 6/6] crypto: qcom: Add ACPI support

From: Timur Tabi
Date: Sat Jul 07 2018 - 14:05:50 EST

On 7/5/18 1:07 AM, Vinod wrote:
Yes we can add driver data in ACPI ID as well so code can be:

if (!has_acpi_companion(&pdev->dev)) {
rng->clk = devm_clk_get(&pdev->dev, "core");
if (IS_ERR(rng->clk))
return PTR_ERR(rng->clk);
rng->skip_init = device_get_match_data(&pdev->dev);

Looks much neater.

Yeah, I like it.

I will wait for feedback on other patches before updating this.

Jeff said it works, so I guess v5 will be good to go.