Re: [PATCH 03/18] fs_context: fix detecting full log buffer

From: David Howells
Date: Mon Jul 09 2018 - 05:33:02 EST


Eric Biggers <ebiggers3@xxxxxxxxx> wrote:

> When 'head' and 'tail' wrap around, 'log->head - log->tail' will be
> something like '4 - 252 = -248', and comparing that directly to the
> array size is wrong. Fix by casting to 'u8'.

I think a better fix is to use CIRC_CNT() or CIRC_SPACE().

David