Re: [PATCH] printk: remove unnecessary kmalloc() from syslog during clear

[Petr Mladek]

On Wed 2018-06-27 17:06:41, Petr Mladek wrote:
> On Tue 2018-06-26 10:39:59, Steven Rostedt wrote:
> > This looks fine. For proper history though, what I do in this case,
> > would be to make this into two patches. One with Namit's original
> > patch, and then a second that removes the code duplication (your patch).
> 
> Proposed patch:
> 
> From: Petr Mladek <pmladek@xxxxxxxx>
> Date: Wed, 27 Jun 2018 16:37:42 +0200
> Subject: [PATCH] printk: Clean up syslog_print_all()
> 
> syslog_print_all() is called twice. Once with a valid buffer
> and once just to set the indexes.
> 
> Both variants are already handled separately. This patch just
> makes it more obvious. It does not change the existing behavior.

JFYI, I have pushed this separate clean up patch into printk.git,
branch for-4.19.

Best Regards,
Petr