Re: [PATCH 07/17] drm/sun4i: DW HDMI: Release nodes if error happens during CRTC search

[Chen-Yu Tsai]

On Sat, Jul 7, 2018 at 1:51 AM, Jernej Skrabec <jernej.skrabec@xxxxxxxx> wrote:
> If error happens in sun8i_dw_hdmi_find_possible_crtcs(), nodes are not
> released with of_node_put() before returning.
>
> Fix that by calling of_node_put() when necessary. While on it, clean up
> the code by using of_graph_get_remote_node() which also lowers number of
> cases where error handling has to be performed.

Good job!

> Fixes: 57e23de02f48 ("drm/sun4i: DW HDMI: Expand algorithm for possible crtcs")
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxx>

Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>