Re: [RFC PATCH v2 10/27] x86/mm: Introduce _PAGE_DIRTY_SW

From: Peter Zijlstra
Date: Wed Jul 11 2018 - 04:45:32 EST


On Tue, Jul 10, 2018 at 03:26:22PM -0700, Yu-cheng Yu wrote:
> + pte = pte_clear_flags(pte, _PAGE_DIRTY_SW);
> return pte_set_flags(pte, _PAGE_DIRTY_HW | _PAGE_SOFT_DIRTY);

Having both _PAGE_DIRTY_SW and _PAGE_SOFT_DIRTY is really confusing.

I'm not sure I have an anwser for this, but urggh.