Re: [PATCH net-next 2/2] tcp: refactor tcp_queue_rcv

From: Eric Dumazet
Date: Wed Jul 11 2018 - 10:57:15 EST


Hi Yafang
On Wed, Jul 11, 2018 at 6:17 AM Yafang Shao <laoar.shao@xxxxxxxxx> wrote:
>
> There're are some code similar to tcp_queue_rcv() in tcp_ofo_queue(),
> so refactor tcp_queue_rcv() to make it be used in tcp_ofo_queue().
>
> After this change, skb->sk is set when skb is moved from ofo queue into
> receive queue instead of when queued into ofo queue.

Why would you do that ???

I urge you to test this on hosts connected to the wild Internet :/