Re: [PATCH v2 1/4] dt-bindings: k3dma: add optional property hisilicon,dma-min-chan

[Rob Herring]

On Mon, Jul 09, 2018 at 04:04:38PM +0530, Vinod wrote:
> On 06-07-18, 11:55, Guodong Xu wrote:
> > From: Li Yu <liyu65@xxxxxxxxxxxxx>
> > 
> > Add optional property hisilicon,dma-min-chan for k3dma.
> > 
> > Signed-off-by: Li Yu <liyu65@xxxxxxxxxxxxx>
> > Signed-off-by: Guodong Xu <guodong.xu@xxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/dma/k3dma.txt | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/dma/k3dma.txt b/Documentation/devicetree/bindings/dma/k3dma.txt
> > index 4945aeac4dc4..f34202a80f3c 100644
> > --- a/Documentation/devicetree/bindings/dma/k3dma.txt
> > +++ b/Documentation/devicetree/bindings/dma/k3dma.txt
> > @@ -12,6 +12,11 @@ Required properties:
> >  		have specific request line
> >  - clocks: clock required
> >  
> > +Optional properties:
> > +- hisilicon,dma-min-chan: the minimum DMA channel number which is usable
> > +		Default value is 0, but in some platform it is
> > +		configured 1, like in hi3660 platform
> > +
> >  Example:
> >  
> >  Controller:
> > @@ -21,6 +26,7 @@ Controller:
> >  			#dma-cells = <1>;
> >  			dma-channels = <16>;
> >  			dma-requests = <27>;
> > +			hisilicon,dma-min-chan = <1>;
> 
> Am still expecting this to be a mask

If so calling it 'min' doesn't make sense. And a mask should have 'mask' 
in the name.

Rob