Re: [PATCH v5 2/7] KVM: arm/arm64: Introduce helpers to manupulate page table entries

From: Punit Agrawal
Date: Wed Jul 11 2018 - 12:10:55 EST


Suzuki K Poulose <Suzuki.Poulose@xxxxxxx> writes:

> On 09/07/18 15:41, Punit Agrawal wrote:
>> Introduce helpers to abstract architectural handling of the conversion
>> of pfn to page table entries and marking a PMD page table entry as a
>> block entry.
>>
>> The helpers are introduced in preparation for supporting PUD hugepages
>> at stage 2 - which are supported on arm64 but do not exist on arm.
>>
>> Signed-off-by: Punit Agrawal <punit.agrawal@xxxxxxx>
>> Acked-by: Christoffer Dall <christoffer.dall@xxxxxxx>
>> Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
>> Cc: Russell King <linux@xxxxxxxxxxxxxxx>
>> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
>> Cc: Will Deacon <will.deacon@xxxxxxx>
>> ---
>
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>

Other than the query on Patch 7 I've incorporated all your suggestions
locally.

Thanks a lot for reviewing the patches.

Punit

ps: Just noticed the typo (manupulate) in the subject. I've fixed it up
locally.