RE: [PATCH 02/31] usb: usbssp: Added some decoding functions.

From: Pawel Laszczak
Date: Thu Jul 12 2018 - 02:28:38 EST


> > This patch add additional functions that converts some fields to string.
> >
> > For example function usbssp_trb_comp_code_string take completion c ode
> > value and return string describing completion code.
>
> Odd line-wrapping :(
Do you mean additional space character between "c" and "ode"

> And why do you want a string for these things? Who cares about them?
It will be used in next version of driver. I have plan to add gadget-debugfs.c file.
At this moment this functions can be useful during debugging driver if someone want to display
some debug information.

Should I remove this function ?

> thanks,
>
> greg k-h