Re: [PATCH] console: Replace #if 1 with a bool to ignore WARN_CONSOLE_UNLOCKED()

From: Sergey Senozhatsky
Date: Thu Jul 12 2018 - 04:06:01 EST


On (07/12/18 09:53), Petr Mladek wrote:
> >
> > True, but at the same time nobody complained that we didn't have those
> > extra WARN_CONSOLE_UNLOCKED()-s. Just saying. Over all I agree that there
> > is probably some value in those extra WARN-s.
>
> I agree that there is some value in the extra WARN's. Also it seems
> that it is useful to disable them for debugging purposes. I do not
> see a better solution. Therefore I am fine with this one.

Good.

> Yes, this extra comment would be appreciated.

Yep.

> If you send v2, please, break also the WARN definition to 80-chars's
> per line ;-)

Yeah, I noticed that too.

Acked-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>

-ss