Re: [PATCH v3 7/7] timex: change syscalls to use struct __kernel_timex

[Christoph Hellwig]

On Fri, Jul 06, 2018 at 10:42:47PM -0700, Deepa Dinamani wrote:
> struct timex is not y2038 safe.
> Switch all the syscall apis to use y2038 safe __kernel_timex.

So you switch existing syscalls to use a different structure.
If this actually happens to be safe it needs a big explanation
in the commit log.

> -#ifdef CONFIG_COMPAT
> -
>  COMPAT_SYSCALL_DEFINE2(clock_adjtime, clockid_t, which_clock,
>  		       struct compat_timex __user *, utp)
>  {
> @@ -1187,10 +1183,6 @@ COMPAT_SYSCALL_DEFINE2(clock_adjtime, clockid_t, which_clock,
>  	return err;
>  }
>  
> -#endif

And this unconditionally defines clock_adjtime, but doesn't actually
seem to add callers, which looks rather odd.  Same for other bits
in the patch.