RE: [PATCH 02/31] usb: usbssp: Added some decoding functions.

[Pawel Laszczak]

> > > > This patch add additional functions that converts some fields to string.
> > > >
> > > > For example function usbssp_trb_comp_code_string take completion c
> > > > ode value and return string describing completion code.
> > >
> > > Odd line-wrapping :(
> > Do you mean additional space character between "c" and "ode"
> 
> It wrapped lines at that point for me, yes.
> 
> > > And why do you want a string for these things?  Who cares about them?
> > It will be used in next version of driver. I have plan to add gadget-debugfs.c
> file.
> > At this moment this functions can be useful during debugging driver if
> > someone want to display some debug information.
> >
> > Should I remove this function ?
> 
> If no one is using it now, yes, it does not need to be there, right?  We don't
> have dead code around for no reason, otherwise someone will come along
> and remove it :)

I checked again, and these functions are used in gadget-trace.h file added in [PATCH 03/31].
I didn't want to create too big patch, so I split it into two separate part. [PATCH 02/31] add debugging 
function used in trace* functions, and [PATCH 03/31/] add all trace* function used in driver.

thanks,

Pawel Laszczak