Re: [PATCH 02/18] block/aoenet: change strncpy+truncation to strlcpy
From: Dominique Martinet
Date: Fri Jul 13 2018 - 11:31:37 EST
Jens Axboe wrote on Fri, Jul 13, 2018:
> This is a weird combination in terms of a single patch, why is
> it patching aoe and gpiolib in one patch?
I must have failed some git add command, I didn't realize they were
together until you pointed it out just now.
This has been discussed more lengthly on the netdev side but the whole
patch serie has been (quite) a bit too hasty; on one side I've been
given some interesting feedback that I would not have gotten just
sending the coccinelle patch first but I really should have waited for
that to land first and most importantly spend more time on each
individual patch, this was rude of me.
I will make sure they are split in a v2, and send them individually
(well, per big component) as self-explaining patches rather than as a
block, once the coccinelle patch has been accepted.
Thank you for the review,
--
Dominique Martinet