Re: [PATCH v5 3/6] crypto: Add Qcom prng driver

[Linus Walleij]

On Mon, Jul 9, 2018 at 8:20 AM Vinod Koul <vkoul@xxxxxxxxxx> wrote:

> This ports the Qcom prng from older hw_random driver.
>
> No change of functionality and move from hw_random to crypto
> APIs is done.
>
> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>

FWIW:
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>


> +config CRYPTO_DEV_QCOM_RNG
> +       tristate "Qualcomm Randon Number Generator Driver"

Random speling error.

> +#include <linux/of_device.h>

Do you need this? It seems like a platform device fair and square.

Yours,
Linus Walleij