Re: [PATCH] staging: ks7010_sdio:Fix checkpatch out of memory warning

From: Greg KH
Date: Mon Jul 16 2018 - 06:02:35 EST


On Fri, Jul 13, 2018 at 09:36:36PM +0530, RAGHU Halharvi wrote:
> * Patch fixes checkpatch warning "Possible unnecessary 'out of memory'
> message"
>
> Signed-off-by: RAGHU Halharvi <raghuhack78@xxxxxxxxx>
> ---
> drivers/staging/ks7010/ks7010_sdio.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index b8f55a11ee1c..972b01a0257d 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -957,10 +957,8 @@ static int send_stop_request(struct sdio_func *func)
> card = sdio_get_drvdata(func);
>
> pp = kzalloc(hif_align_size(sizeof(*pp)), GFP_KERNEL);
> - if (!pp) {
> - netdev_err(card->priv->net_dev, "allocate memory failed..\n");
> + if (!pp)
> return -ENOMEM;
> - }

This change has already been done in my tree, please always work against
linux-next at the least, and ideally staging.git, so that you do not
duplicate work others have already done.

thanks,

greg k-h