Re: [PATCH v2] base: core: Remove WARN_ON from link dependencies check

From: Greg KH
Date: Mon Jul 16 2018 - 06:27:40 EST


On Mon, Jul 16, 2018 at 12:07:20PM +0200, Rafael J. Wysocki wrote:
> On Monday, July 16, 2018 11:59:52 AM CEST Benjamin Gaignard wrote:
> > In some cases the link between between customer and supplier
> > already exist, for example when a device use it parent as supplier [1].
>
> I think this should be "its parent as a supplier".
>
> > Do not warn about already existing dependencies because device_link_add()
> > take care of this case.
>
> "device_link_add() takes care of"
>
> > [1] https://lkml.org/lkml/2018/7/9/356
>
> There is the Link: tag for links and it is better to not use lkml.org
> as it is not reliable enough. You can use lore.kernel.org/lkml/ instead.

Even better, use:
lkml.kernel.org/r/[message-id]

thanks,

greg k-h