Re: [PATCH v4 2/2] ARM: dts: am335x: add am335x-sancloud-bbe board support

[Koen Kooi]

> Op 17 jul. 2018, om 08:16 heeft Tony Lindgren <tony@xxxxxxxxxxx> het volgende geschreven:
> 
> Hi Koen,
> 
> Just noticed there should be generic node names here too, see below.
> 
> * Koen Kooi <koen@xxxxxxxxxxxxxxxxxxxxx> [180713 06:28]:
>> The "Beaglebone Enhanced" by Sancloud is based on the Beaglebone Black,
>> but with the following differences:
>> 
>> * Gigabit capable PHY
>> * Extra USB hub, optional i2c control
>> * lps3331ap barometer connected over i2c
>> * MPU6050 6 axis MEMS accelerometer/gyro connected over i2c
>> * 1GiB DDR3 RAM
>> * RTL8723 Wifi/Bluetooth connected over USB
> 
>> +&i2c0 {
>> +	lps331ap: lps331ap@5C {
>> +		compatible = "st,lps331ap-press";
>> +		st,drdy-int-pin = <1>;
>> +		reg = <0x5C>;
>> +		interrupt-parent = <&gpio1>;
>> +		interrupts = <26 IRQ_TYPE_EDGE_RISING>;
>> +	};
> 
> lps33lap: barometer@5c
> 
>> +	mpu6050: mpu6050@68 {
>> +		compatible = "invensense,mpu6050";
>> +		reg = <0x68>;
>> +		interrupt-parent = <&gpio0>;
>> +		interrupts = <2 IRQ_TYPE_EDGE_RISING>;
>> +		orientation = <0xff 0 0 0 1 0 0 0 0xff>;
>> +	};
> 
> mpu6050: accelerometer@2c
> 
> And so on. Please check the lower case hex numbers too as
> thatâs what Linux typically uses.

Thanks for the feedback! Fixed both issues, v5 sent out. 

regards,

Koen

> 
> Thanks,
> 
> Tony