Re: [PATCH] dma-mapping: Relax warnings for per-device areas

From: Christoph Hellwig
Date: Thu Jul 19 2018 - 09:13:34 EST


On Wed, Jul 18, 2018 at 02:55:59PM -0700, Geoff Levand wrote:
> Hi,
>
> On 07/17/2018 09:33 AM, Fredrik Noring wrote:
> >>> Here are three other regressions related to the coherent mask WARN_ON_ONCE:
> >>
> >> They are a pretty strong indication that yes, you should really set
> >> the coherent mask if you ever do coherent allocations..
> >
> > I'm unfortunately unfamiliar with the USB drivers for the PS3. Geoff, what
> > do you think about setting a coherent mask?
>
> I guess we need to add a dma_set_coherent_mask() call in the driver
> probe routines. I'll send out a patch.

Yes, exactly!