Re: [PATCH] arch/h8300: fix kernel/dma.c build warning

From: Geert Uytterhoeven
Date: Sun Jul 22 2018 - 05:26:14 EST


CC hexagon

hexagon != H8/300 != SuperH

On Sat, Jul 21, 2018 at 5:17 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Fix build warning in arch/hexagon/kernel/dma.c by casting a void *
> to unsigned long to match the function parameter type.
>
> ../arch/hexagon/kernel/dma.c: In function 'arch_dma_alloc':
> ../arch/hexagon/kernel/dma.c:51:5: warning: passing argument 2 of 'gen_pool_add' makes integer from pointer without a cast [enabled by default]
> ../include/linux/genalloc.h:112:19: note: expected 'long unsigned int' but argument is of type 'void *'
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
> Cc: Rich Felker <dalias@xxxxxxxx>
> Cc: linux-sh@xxxxxxxxxxxxxxx
> ---
> arch/hexagon/kernel/dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20180717.orig/arch/hexagon/kernel/dma.c
> +++ linux-next-20180717/arch/hexagon/kernel/dma.c
> @@ -47,7 +47,7 @@ void *arch_dma_alloc(struct device *dev,
> panic("Can't create %s() memory pool!", __func__);
> else
> gen_pool_add(coherent_pool,
> - pfn_to_virt(max_low_pfn),
> + (unsigned long)pfn_to_virt(max_low_pfn),
> hexagon_coherent_pool_size, -1);
> }
>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds