Re: [PATCH] m68k/mac: Rework patch "use time64_t in RTC handling"

From: Arnd Bergmann
Date: Tue Jul 24 2018 - 05:23:18 EST


On Tue, Jul 24, 2018 at 9:07 AM, Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
> This addresses the issues arising from commit 324caa29cd04
> ("m68k: mac: use time64_t in RTC handling").
>
> Adopt __u32 for the union in via_read_time(), consistent with changes
> to via_write_time().
>
> Use low_32_bits() in via_write_time(), consistent with changes to
> pmu_write_time() and cuda_write_time().
>
> Have via_read_time() return a time64_t, consistent with changes to
> pmu_read_time and cuda_read_time().
>
> Drop the pointless wraparound conditional in via_read_time().
>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>

Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>

Thanks for fixing it up!