Re: [PATCHv3 1/3] mm: Introduce vma_init()

From: Kirill A. Shutemov
Date: Wed Jul 25 2018 - 08:39:34 EST


On Tue, Jul 24, 2018 at 01:41:58PM -0700, Andrew Morton wrote:
> On Tue, 24 Jul 2018 13:16:33 -0700 Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> > On Tue, Jul 24, 2018 at 1:03 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > >
> > > I'd sleep better if this became a kmem_cache_alloc() and the memset
> > > was moved into vma_init().
> >
> > Yeah, with the vma_init(), I guess the advantage of using
> > kmem_cache_zalloc() is pretty dubious.
> >
> > Make it so.
> >
>
> Did I get everything?

There are few more:

arch/arm64/include/asm/tlb.h: struct vm_area_struct vma = { .vm_mm = tlb->mm, };
arch/arm64/mm/hugetlbpage.c: struct vm_area_struct vma = { .vm_mm = mm };
arch/arm64/mm/hugetlbpage.c: struct vm_area_struct vma = { .vm_mm = mm };

--
Kirill A. Shutemov