Re: [linux-sunxi] [PATCH v3 6/9] dt-bindings: phy: add binding for Allwinner USB3 PHY
From: Rob Herring
Date: Wed Jul 25 2018 - 11:31:30 EST
On Sun, Jul 22, 2018 at 02:10:33PM +0800, Chen-Yu Tsai wrote:
> On Sun, Jul 22, 2018 at 1:57 PM, Icenowy Zheng <icenowy@xxxxxxx> wrote:
> > The new Allwinner H6 SoC contains a USB3 PHY that is wired to the
> > external USB3 pins of the SoC.
> > Add a device tree binding for the PHY.
> > Signed-off-by: Icenowy Zheng <icenowy@xxxxxxx>
> > Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>
> > ---
> > Changes in v3:
> > - Added Chen-Yu's Review tag.
> > Rob,
> > Although you mentioned that the supply is for the port, not the phy;
> > currently in USB situation "powering on the PHY" also indicates
> > "powering on the port" and nearly all usages of phy-supply is for Vbus.
> > Maybe we should change the overall phy-supply to satisfy this.
> Or maybe change it to vbus-supply, like we have for phy-sun4i-usb,
> until USB port power sequencing is added. (I remember there were
> patches for this. What happened?)
Once it is in the binding, we are stuck with it.
Connector bindings have landed. We should add vbus-supply to that. You
don't have to have a property in the node associated with a driver. The
phy driver can walk the tree and get the Vbus supply.
UniPhier has the same issue.