Re: [PATCH 1/2] mmc: tmio: rename files and CONFIG options to have the same prefix

From: Geert Uytterhoeven
Date: Thu Jul 26 2018 - 04:25:51 EST

Hi Yamada-san,

On Thu, Jul 26, 2018 at 5:33 AM Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
> As commit b6147490e6aa ("mmc: tmio: split core functionality, DMA and
> MFD glue") said, these MMC controllers use the IP from Panasonic.
> TMIO (Toshiba Mobile IO) MMC was the first upstreamed user of this IP.
> The common driver code was split and expanded as 'tmio-mmc-core', then
> it become historical misnomer since 'tmio' is not the name of this IP.
> I pointed out this [1], and suggested to re-organize the names in the
> form of:
> <IP-name>.c (common code for this IP)
> <IP-name>_tmio.c (Toshiba Mobile IO)
> <IP-name>_sdhi.c (Renesas SDHI)
> <IP-name>_uniphier.c (Socionext UniPhier)
> The <IP-name> in my mind was 'mnsd' because names of Panasonic chips
> are prefixed with 'MN'.
> This is the naming scheme as we see in dw_mmc* and sdhci-*.
> In the discussion with Wolfram Sang, my suggestion was rejected
> because it implied drastic function renaming, which is too invasive.
> Ulf Hansson was still happy with file renaming to clarify the
> relationship between variants. So, the accepted solution was:
> - Make 'tmio_mmc' the _right_ core name
> - Align all variant files with the same prefix.
> - Do not rename functions
> This commit renames files as follows:
> tmio_mmc_core.c -> tmio_mmc.c
> tmio_mmc.c -> tmio_mmc_original.c
> renesas_sdhi_core.c -> tmio_mmc_sdhi.c
> renesas_sdhi.h -> tmio_mmc_sdhi.h
> renesas_sdhi_internal_dmac.c -> tmio_mmc_sdhi_internal_dmac.c
> renesas_sdhi_sys_dmac.c -> tmio_mmc_sdhi_sys_dmac.c

I have mixed feelings about the last two renames, especially about the last
one: SYS-DMAC is very Renesas-specific, as it's a separate IP block in
Renesas SoCs.
1. Are there other SoCs using the same internal DMAC?
If not, perhaps the "renesas" should be kept in the driver name?
2. Are there other SoCs using an external DMAC?
Is the interface to the external DMAC similar?
If yes, perhaps it should be renamed to tmio_mmc_sdhi_external_dmac.c?
If not, perhaps the "renesas" should be kept in the driver name?




Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds