Re: [PATCH 7/7] net: phy: Add pm support for scan ctrl register to bcm mdio mux
From: Arun Parameswaran
Date: Thu Jul 26 2018 - 15:50:51 EST
On 18-07-26 12:36 PM, Andrew Lunn wrote:
> On Thu, Jul 26, 2018 at 12:33:05PM -0700, Arun Parameswaran wrote:
>> On 18-07-26 12:20 PM, Andrew Lunn wrote:
>>> On Thu, Jul 26, 2018 at 11:36:24AM -0700, Arun Parameswaran wrote:
>>>> Add support for saving and restoring the 'scan control' register
>>>> in the Broadcom iProc mdio mux driver.
>>> Hi Arun
>>> I don't see anything setting this register. So why is it necessary to
>>> save it over suspend/resume?
>> Hi Andrew
>> In the Omega SoC (only), this register was defaulted incorrectly (to use
>> a test mode) by the hardware. So we added the setup of the register to
>> the early bootloader (ATF).
>> We still need to restore this register while resuming from sleep.
> Hi Arun
> It is better to not rely on the bootloader and have the driver do it.
> That makes it easier for people to swap to alternative bootloaders.
I will make the change to set the register in the driver.