Re: [PATCH 34/38] vfs: syscall: Add fsinfo() to query filesystem information [ver #10]

From: Andy Lutomirski
Date: Fri Jul 27 2018 - 15:35:33 EST


On Fri, Jul 27, 2018 at 10:35 AM, David Howells <dhowells@xxxxxxxxxx> wrote:
> Add a system call to allow filesystem information to be queried. A request
> value can be given to indicate the desired attribute. Support is provided
> for enumerating multi-value attributes.

Has anyone seriously reviewed this? It might make sense to defer this
to a followup patch set. Also:

> params->request indicates the attribute/attributes to be queried. This can
> be one of:
>
> fsinfo_attr_statfs - statfs-style info
> fsinfo_attr_fsinfo - Information about fsinfo()

Constants are almost always all caps. Is there any reason these are lowercase?