Re: [PATCH net-next] net: ethernet: ti: cpsw: replace unnecessarily macroses on functions

From: Andrew Lunn
Date: Fri Jul 27 2018 - 16:32:12 EST


> +static inline void cpsw_src_port_detect(struct cpsw_common *cpsw, int status,
> + struct sk_buff *skb)

Please don't use inline. Let the compiler decide.

Andrew