Re: [PATCH v2 2/3] tty: Make constants to be enums instead of #define in goldfish.c

From: Greg KH
Date: Sat Jul 28 2018 - 10:51:18 EST

On Tue, Jul 24, 2018 at 05:51:32PM -0700, rkir@xxxxxxxxxx wrote:
> From: Roman Kiryanov <rkir@xxxxxxxxxx>
> enums produce better compilation errors than defines.

Yes, they can, if you use them correctly. Which you are not doing here,
so this patch really does nothing. Why should we take it?


greg k-h