Re: [PATCH] x86/apic: fix two slight indenting

From: wang.yi59
Date: Mon Jul 30 2018 - 02:17:29 EST


Thanks a lot, Steven.


---

Best wishes

Yi Wang

Original Mail
Sender: StevenRostedt <rostedt@xxxxxxxxxxx>
To: Wang Yi10129963;
CC: tglx@xxxxxxxxxxxxx <tglx@xxxxxxxxxxxxx>mingo@xxxxxxxxxx <mingo@xxxxxxxxxx>hpa@xxxxxxxxx <hpa@xxxxxxxxx>x86@xxxxxxxxxx <x86@xxxxxxxxxx>douly.fnst@xxxxxxxxxxxxxx <douly.fnst@xxxxxxxxxxxxxx>jgross@xxxxxxxx <jgross@xxxxxxxx>ville.syrjala@xxxxxxxxxxxxxxx <ville.syrjala@xxxxxxxxxxxxxxx>len.brown@xxxxxxxxx <len.brown@xxxxxxxxx>linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>gregkh@xxxxxxxxxxxxxxxxxxx <gregkh@xxxxxxxxxxxxxxxxxxx>Jiang Biao10062664;Zhong Weidong10001088;trivial@xxxxxxxxxx <trivial@xxxxxxxxxx>
Date: 2018/07/27 23:33
Subject: Re: [PATCH] x86/apic: fix two slight indenting

This looks like it should go through the trivial tree. Although I'm not
the maintainer of this code, it looks reasonable to me, and I'll give
my:

Acked-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

-- Steve


On Fri, 27 Jul 2018 14:15:03 +0800
Yi Wang <wang.yi59@xxxxxxxxxx> wrote:

> There are two inconsistent indenting in calibrate_APIC_clock()
> and activate_managed(). Remove the surplus TAB.

> Signed-off-by: Yi Wang <wang.yi59@xxxxxxxxxx>
> Reviewed-by: Jiang Biao <jiang.biao2@xxxxxxxxxx>
> ---
>  arch/x86/kernel/apic/apic.c   | 2 +-
>  arch/x86/kernel/apic/vector.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index 5071cc7..f222ebc 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -937,7 +937,7 @@ static int __init calibrate_APIC_clock(void)
>  
>      if (levt->features & CLOCK_EVT_FEAT_DUMMY) {
>          pr_warning("APIC timer disabled due to verification failure\n");
> -            return -1;
> +        return -1;
>      }
>  
>      return 0;
> diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
> index b708f59..19e0b2f 100644
> --- a/arch/x86/kernel/apic/vector.c
> +++ b/arch/x86/kernel/apic/vector.c
> @@ -433,7 +433,7 @@ static int activate_managed(struct irq_data *irqd)
>          pr_err("Managed startup irq %u, no vector available\n",
>                 irqd->irq);
>      }
> -       return ret;
> +    return ret;
>  }
>  
>  static int x86_vector_activate(struct irq_domain *dom, struct irq_data *irqd,