Re: [PATCH v2 4/4] ARC: don't check for HIGHMEM pages in arch_dma_alloc

From: Christoph Hellwig
Date: Tue Jul 31 2018 - 04:04:37 EST


On Mon, Jul 30, 2018 at 07:26:36PM +0300, Eugeniy Paltsev wrote:
> __GFP_HIGHMEM flag is cleared by upper layer functions
> (in include/linux/dma-mapping.h) so we'll never get a
> __GFP_HIGHMEM flag in arch_dma_alloc gfp argument.
> That's why alloc_pages will never return highmem page
> here.
>
> Get rid of highmem pages handling and cleanup arch_dma_alloc
> and arch_dma_free functions.
>
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@xxxxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>