Sure, I can merge them into core in next version.I haven't look at them in a while, but maybe theirs are optional?Any particular reason for separating out IRQ handling?No particular reason, I tried to follow what other codecs like wm8994,
wm8350 and 14 others do.
Either way, I don't think you need to do it.
I guess now you have seen my comment below, you know that it canIt would not defer here as the regmaps are already setup in probe and theinclude/dt-bindings/mfd/wcd9335.h | 43 +++++++++Why don't you check the return value?
include/linux/mfd/wcd9335/wcd9335.h | 3 +
5 files changed, 228 insertions(+), 1 deletion(-)
create mode 100644 drivers/mfd/wcd9335-irq.c
create mode 100644 include/dt-bindings/mfd/wcd9335.h
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index a4697370640b..210875afe78a 100644
@@ -58,7 +58,7 @@ obj-$(CONFIG_MFD_ARIZONA) += cs47l24-tables.o
obj-$(CONFIG_MFD_WCD9335) += wcd9335.o
-wcd9335-objs := wcd9335-core.o
+wcd9335-objs := wcd9335-core.o wcd9335-irq.o
obj-$(CONFIG_MFD_WM8400) += wm8400-core.o
wm831x-objs := wm831x-core.o wm831x-irq.o wm831x-otp.o
diff --git a/drivers/mfd/wcd9335-core.c b/drivers/mfd/wcd9335-core.c
index 8f746901f4e9..6299dfb63aca 100644
@@ -243,12 +243,20 @@ static int wcd9335_slim_status(struct slim_device *sdev,
What happens if it defers?
status callback is only invoked when the SLIMbus device is up.
Yes, I mean I agree with you and will fix this in next version.
Does "yep" mean, "I'll fix it"?Yep.+// SPDX-License-Identifier: GPL-2.0Blank line?
+// Copyright (c) 2018, Linaro Limited