Re: [PATCH] misc: eeprom: assignment outside the if statement

[Parth Shah]

Hello Jean,

Thank you for your response.

So, can we consider this patch?

Regards,

Parth Y Shah

On Fri, Aug 3, 2018 at 6:06 PM Jean Delvare <jdelvare@xxxxxxx> wrote:

On Fri, 3 Aug 2018 14:50:43 +0530, Parth Y Shah wrote:
> Assignment of any variable should be kept outside the if statement

Actually there are exceptions to that rule, but this isn't one of them.

> Signed-off-by: Parth Y Shah <sparth1292@xxxxxxxxx>
> ---
>Â drivers/misc/eeprom/max6875.c | 3 ++-
>Â 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/eeprom/max6875.c b/drivers/misc/eeprom/max6875.c
> index 0e32709..fc0cf9a 100644
> --- a/drivers/misc/eeprom/max6875.c
> +++ b/drivers/misc/eeprom/max6875.c
> @@ -148,7 +148,8 @@ static int max6875_probe(struct i2c_client *client,
>Â Â Â Âif (client->addr & 1)
>Â Â Â Â Â Â Â Âreturn -ENODEV;
>Â
> -Â Â Âif (!(data = "" max6875_data), GFP_KERNEL)))
> +Â Â Âdata = "" max6875_data), GFP_KERNEL);
> +Â Â Âif (!data)
>Â Â Â Â Â Â Â Âreturn -ENOMEM;
>Â
>Â Â Â Â/* A fake client is created on the odd address */

Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>

Thanks,
--
Jean Delvare
SUSE L3 Support